Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify main branch in configuration #107

Closed
wants to merge 3 commits into from

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Jan 26, 2023

running asv gh-pages results in an error as it assumes the default branch is named master; this is a small fix to make that work

@pllim
Copy link
Member

pllim commented Jan 26, 2023

This repo has been inactive for a long time and we're pondering a completely different way to benchmark over here:

Can you please justify why this PR is needed? There is no description in your PR original post. Thanks!

@nden
Copy link
Contributor

nden commented Jan 26, 2023

Just to clarify a bit. We started running the astropy benchmarks here at STScI and would like to post the results at the usual place (something that will be discussed at the next astropy infrastructure meeting). Zach will clarify the issue with the branch naming. I don't want to impose a solution on how to run the benchmarks. If the project decides to go a different way that's fine. We need some estimates now and the easiest and fastest way to get these estimates is to run use what we already have.

@pllim
Copy link
Member

pllim commented Jan 26, 2023

something that will be discussed at the next astropy infrastructure meeting

Okay. Do you want to keep this open until after the meeting? I don't have a problem merging it now as it looks uncontroversial but I just want to make sure STScI knows Astropy's plan (or lack of). Please let know.

Also, if you need invites to the meeting, please DM me. Thanks!

@pllim
Copy link
Member

pllim commented Feb 28, 2023

It is my understanding that @zacharyburnett would open a separate PR to sync his fork to this repo, which would also include this patch, so closing without merge. cc @WilliamJamieson

Thanks for your patience!

@pllim pllim closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants